Simplify RuntimeContainer #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-sully
approved these changes
Jul 14, 2023
Comment on lines
+14
to
+15
| instance_number = split(".")[1].to_i | ||
| instance_number > 1 |
There was a problem hiding this comment.
Is this working off the basis that nil.to_i is 0? 😆
| @api_base_url ||= "https://adapter.judoscale.com/api/#{ENV["RENDER_SERVICE_ID"]}" | ||
| elsif ENV["DYNO"] | ||
| service_name, instance = ENV["DYNO"].split "." | ||
| @current_runtime_container = RuntimeContainer.new service_name, instance | ||
| @current_runtime_container = RuntimeContainer.new ENV["DYNO"] | ||
| else | ||
| # unsupported platform? Don't want to leave @current_runtime_container nil though |
There was a problem hiding this comment.
Might want to drop this comment now 🤔
There was a problem hiding this comment.
Is it no longer valid? I still found it helpful, assuming we don't want @current_runtime_container to be nil.
There was a problem hiding this comment.
We don't, but the "unsupported platform" bit isn't a valid assumption anymore, now that we know there are platforms which the correct functionality is to have the bare RuntimeContainer.new 🤔 so maybe just the first 2 words of the comment 😆
We have no use for `service_name`, so we can treat the runtime container as just the container ID.
adamlogic
force-pushed
the
am-simplify-runtime-container
branch
from
be6aeda
to
4563363
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have no use for
service_name, so we can treat the runtime container as just the container ID. This also preps us for ECS, where we don't have access to the service name.